Skip to content

fix: Ensure the converter runs to_snowflake on list items #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Ensure the converter runs to_snowflake on list items #2312

wants to merge 2 commits into from

Conversation

jeffsawatzky
Copy link

@jeffsawatzky jeffsawatzky commented May 6, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2090775: converter doesn't properly convert lists of bytes #2311

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    When the converter is converting a list, it isn't running to_snowflake on each element like it does when it is a single parameter.

  4. (Optional) PR for stored-proc connector:

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeffsawatzky jeffsawatzky mentioned this pull request May 6, 2025
Closed
@jeffsawatzky
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jeffsawatzky
Copy link
Author

recheck

@sfc-gh-pbulawa
Copy link
Contributor

Thank you for the PR. Could you please add a test for that case?

@jeffsawatzky
Copy link
Author

@sfc-gh-pbulawa I added a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mkubik sfc-gh-mkubik Awaiting requested review from sfc-gh-mkubik

@sfc-gh-mmishchenko sfc-gh-mmishchenko Awaiting requested review from sfc-gh-mmishchenko

@sfc-gh-pbulawa sfc-gh-pbulawa Awaiting requested review from sfc-gh-pbulawa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-2090775: converter doesn't properly convert lists of bytes
2 participants
@jeffsawatzky @sfc-gh-pbulawa